Chameleon Commit Details - 2296 - Chameleon open source boot loader project.

Date:

2014-01-07 08:24:34 (10 years 3 months ago)

Author:

Chuck Fry

Commit:

2296

Parents:

2295

Message:

sym_expand_string_value(): fix cppcheck errors; more to be done here

Changes:

M	/branches/chucko/i386/config/symbol.c

File differences

-881
882 882
883 883
884 
885 
884
885
886
887
888
889
890
886 891
887 892
888 893
+␊
␉␉newlen = strlen(res) + strlen(symval) + strlen(src) + 1;␊
␉␉if (newlen > reslen) {␊
␉␉␉reslen = newlen;␊
␉␉␉res = realloc(res, reslen);␊
          char* newres = NULL;␊
          if (!(newres = realloc(res, newlen))) {␊
            /* TODO: handle error gracefully - for now, punt */␊
            break;␊
          }␊
          res = newres;␊
          reslen = newlen;␊
␉␉}␊
␊
␉␉strcat(res, symval);␊
 ␊
 ␉␉newlen = strlen(res) + strlen(symval) + strlen(src) + 1;␊
 ␉␉if (newlen > reslen) {␊
-␉␉␉reslen = newlen;␊
-␉␉␉res = realloc(res, reslen);␊
+          char* newres = NULL;␊
+          if (!(newres = realloc(res, newlen))) {␊
+            /* TODO: handle error gracefully - for now, punt */␊
+            break;␊
+          }␊
+          res = newres;␊
+          reslen = newlen;␊
 ␉␉}␊
 ␊
 ␉␉strcat(res, symval);␊