Chameleon Commit Details - 2298 - Chameleon open source boot loader project.

Date:

2014-01-07 09:17:53 (10 years 3 months ago)

Author:

Chuck Fry

Commit:

2298

Parents:

2297

Message:

AllocateMemoryRange: fix cppcheck detected memory leak

Changes:

M	/branches/chucko/i386/libsaio/allocate.c

File differences

-41
42 42
43 43
44 
45 44
46 45
47 
46
47
48
49
48 50
51
49 52
50 53
51 54
+    ␊
    nameBuf = malloc(strlen(rangeName) + 1);␊
    if (nameBuf == 0) return -1;␊
    strcpy(nameBuf, rangeName);␊
    ␊
    buffer = malloc(2 * sizeof(uint32_t));␊
    if (buffer == 0) return -1;␊
    if (buffer == 0) {␊
      free(nameBuf);␊
      return -1;␊
    }␊
    ␊
    strcpy(nameBuf, rangeName);␊
    buffer[0] = start;␊
    buffer[1] = length;␊
    ␊
     ␊
     nameBuf = malloc(strlen(rangeName) + 1);␊
     if (nameBuf == 0) return -1;␊
-    strcpy(nameBuf, rangeName);␊
     ␊
     buffer = malloc(2 * sizeof(uint32_t));␊
-    if (buffer == 0) return -1;␊
+    if (buffer == 0) {␊
+      free(nameBuf);␊
+      return -1;␊
+    }␊
     ␊
+    strcpy(nameBuf, rangeName);␊
     buffer[0] = start;␊
     buffer[1] = length;␊
     ␊