Chameleon

Issue 176: Memory leak in getValueForBootKey

Reported by J Guerrero, Sep 6, 2011

If send two options with same name this function creates a memory 
leak because it search and get the last one.

Attached a preliminar patch

Comment 1 by armel cadet-petit, Sep 10, 2011

hi, i don't see any attached file  ...

Comment 2 by JrCs, Oct 22, 2011

Status: AwaitingInformation

Comment 3 by Cosmosis Jones, Nov 3, 2011

I dont' quite understand how thats a memeory leak. If you supply 2 
options w/ the same name, which one should it take..
by design, it takes the LAST one.

Why are u putting in 2 values w/ the same name.

Does this cause chaemleon to crash?

Comment 4 by Evan Lojewski, Nov 5, 2011

Yes, the getValueForBootKey leaks memory, it was specifically 
written this way... I can be fixed, but it's not a high priority 
issue (if you reattach the patch, we'll look into it)

We are in a boot loader, The only reason for us *not* to leak memory 
is so that the zalloc.c functions have enough nodes to give out. 
Other than that, once the OS starts up, the memory isn't allocated 
as far as the OS is concerned.

Comment 5 by Cosmosis Jones, May 8, 2012

Status: WontFix

Created: 7 years 2 months ago by J Guerrero

Updated: 6 years 6 months ago

Status: WontFix

Followed by: 4 persons

Labels:
Priority:Medium
Type:Defect