Issue 75: manufacturer & product blank in SMBIOS Record Type 2 - Chameleon open source boot loader project.

Reported by MacMan, May 24, 2011

In the latest trunk version manufacturer & product are blank in 
SMBIOS Record Type 2. This causes an issue with Geekbench reporting 
nothing for Motherboard. SMboardproduct is being read from 
/Extra/smbios.plist and is being inserted into IORegistry correctly. 
It's just not being stored in the SMBIOS.

Here is the output from bdmesg:

Type: 2, Length: 8, Handle: 0x2
BaseBoard:
	manufacturer: 
	product: 
	version: ?
	serialNumber: ?
	assetTagNumber: ?
	locationInChassis: 
	boardType: 0x20

manufacturer should be "Apple Inc." just like it is in the 
Type 1 record and product should be "Mac-F42C88C8" just 
like "SMboardproduct" is in smbios.plist

Comment 1 by Kabyl, May 24, 2011

Upload your .ioreg.

Owner: Kabyl

Comment 2 by MacMan, May 24, 2011

Here you go.

Storm_Sniper.zip - 559.40 kB

Comment 3 by Kabyl, May 24, 2011

Was this working on this board before?

Comment 4 by MacMan, May 24, 2011

Yes, it stopped working around trunk r833 when the SMBIOS code was 
overhauled. I tried trunk r760 with the old SMBIOS code and it's 
fine.

Comment 5 by Kabyl, May 24, 2011

I see now, you didn't merge my last changes where I fixed this, 
please do report.

Comment 6 by MacMan, May 24, 2011

I've tired my branch (updated to trunk r874) and trunk revision 874 
with the same results.

I noticed in the last commit you did 863, that most of the new is 
identical to the old, 
http://forge.voodooprojects.org/p/chameleon/source/commit/863/.

Comment 7 by Kabyl, May 24, 2011

Removed spaces, but the fix is in 2 lines; 609, 610.

Comment 8 by MacMan, May 24, 2011

I verified that those 2 lines are in both source files used for the 
make. I keep my source separate from the trunk code.

Comment 9 by Kabyl, May 24, 2011

In your first post of the issue, you said "latest trunk", 
but I went further and checked your branch (which doesn't seem to 
have the fix), and the ioreg you posted uses your branch.

Comment 10 by MacMan, May 24, 2011

I am working locally with a newer version of my branch based on the 
latest trunk. I haven't committed it yet as I was trying to fix this 
issue on my own.

Comment 11 by Kabyl, May 24, 2011

It could be an bug elsewhere, I wouldn't know since I don't have 
your sources, are you able to test current trunk?

This just looks the same as issue #73

Comment 12 by MacMan, May 24, 2011

I tested with the current trunk and it behaves the same. If you want 
an IOReg from that I can supply.

As for closed issue 73, it's different. In that case it wasn't 
inserting SMboardproduct into IOReg. As best as I can tell the 
problem is that either the manufacturer & product info is not 
being written or it's getting overwritten with whitespace in the 
SMBIOS Type 2 record.

Comment 13 by Kabyl, May 24, 2011

yes, please upload the ioreg.

Comment 14 by MacMan, May 24, 2011

Here you go.

Storm_Sniper-trunk_874.zip - 630.22 kB

Comment 15 by Kabyl, May 24, 2011

Try the attached booter.

boot.gz - 211.37 kB

Comment 16 by MacMan, May 24, 2011

Nope, still blank in Geekbench, here is bdmesg and ioreg.

test-bdmesg.txt.zip - 2.76 kB
test-ioreg.zip - 558.64 kB

Comment 17 by Kabyl, May 25, 2011

Another test.

boot.gz - 211.38 kB

Comment 18 by MacMan, May 25, 2011

Still blank.

test2-bdmesg.txt.zip - 2.80 kB
test2-ioreg.zip - 571.43 kB

Comment 19 by Kabyl, May 25, 2011

Thanks, I think this one should work.

boot.gz - 211.35 kB

Comment 20 by MacMan, May 25, 2011

Perfect!

Type: 2, Length: 8, Handle: 0x2
BaseBoard:
	manufacturer: Apple Inc.
	product: Mac-F42C88C8
	version: ?
	serialNumber: ?
	assetTagNumber: 
	locationInChassis: 
	boardType: 0x20

Thank you very much for fixing this.

Comment 21 by Kabyl, May 25, 2011

And thank you for your patience and feedback.
commit to follow..

Status: Verified