Chameleon

Issue 252: Commit 1951 - Broken boot

Reported by blackosx, May 8, 2012

For me, rev1951 results in Boot2 either not loading or maybe loading 
initially, but all I see is a flashing underscore?

Rev1950 is fine.

Comment 1 by Cosmosis Jones, May 9, 2012

checking thanks
Status: Accepted
Owner: cosmo1t

Comment 2 by Cosmosis Jones, May 9, 2012

reverted
please test
Status: Fixed

Comment 3 by blackosx, May 9, 2012

Reverting puts it back to booting. 

However looking this morning at why it broke, I see the problem was 
a typo in line 67 of /i386/libsaio/saio_types.h

commit 1951 had:
	char	plist[163840];	// buffer for plist

removing the erroneous 0 to leave 16K works.
	char	plist[16384];	// buffer for plist

This should now work as originally intended.

Comment 4 by Cosmosis Jones, May 9, 2012

unfortunately, that doesn't solve the 40*4096 issue (the maximum 
reading size)

Comment 5 by Cosmosis Jones, May 9, 2012

#define CONFIG_SIZE (40 * 4096)

/*
 * Max size for config data array, in bytes.
 */
#define IO_CONFIG_DATA_SIZE		163840

Comment 6 by Cosmosis Jones, May 9, 2012

so i dont' know why we can't allocate that same size to the plist 
array.. i'm not going to fix it either..

we can leave it at 4k, or bump it to 16k, but either way, it still 
has the same potential overflow

Created: 6 years 6 months ago by blackosx

Updated: 6 years 6 months ago

Status: Fixed

Owner: Cosmosis Jones

Labels:
Type:Defect
Priority:Critical