Issue 280: Fix crash with missing *_o.png image

Reported by bltz, Aug 14, 2012

If a *_o.png image is missing from the theme but the corresponding 
image is there, the gui crashes when an icon using it is selected. 
This is due to the wrong use of the alternate images for the *_o.png 
override images: they were set to themselves which is non-sense. The 
alternate images were meant to be fallbacks for missing images.

The attached patch corrects the alternate images of the optional 
images so that there's always a valid fallback and also contains 
some cleanups and simplifications made possible by having correct 
fallbacks now.

Comment 1 by bltz, Aug 14, 2012


LOADPNG(device_hfsraid, iDeviceGeneric);

should probably be

LOADPNG(device_hfsraid, iDeviceHFS);

in the attached patch...

Comment 2 by ErmaC , Aug 14, 2012

Thx bltz.
I merge the patch in my branch.


Comment 3 by Cosmosis Jones, Oct 29, 2012

Status: Fixed

Created: 9 years 2 months ago by bltz

Updated: 8 years 11 months ago

Status: Fixed

Followed by: 2 persons